Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Make LoadingAnimation conditional #175

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Refactor: Make LoadingAnimation conditional #175

merged 3 commits into from
Mar 29, 2024
+25 −28

Conversation

GabeDiniz
Copy link
Contributor

✨ Issue: #174
🔀 Branch: refactor/174/hardcoded-loading-animation

✏ What was changed?

  • Quick fix for loading animation. I made it conditional so it waits for the HeroAbout section to render instead of hard coding it to 3 seconds.

Suggestion

  • Let me know if you guys want me to add a minimum time to the loader. I.e., the loading animation is present for a minimum of 2 seconds or until the component loads.

@GabeDiniz GabeDiniz self-assigned this Mar 27, 2024
@GabeDiniz GabeDiniz requested a review from aidantrabs as a code owner March 27, 2024 23:20
@GabeDiniz GabeDiniz linked an issue Mar 27, 2024 that may be closed by this pull request
[Fix] Loading Animation duration is hard coded #174
Closed
@aidantrabs aidantrabs merged commit 65cbc41 into main Mar 29, 2024
3 checks passed
@aidantrabs aidantrabs deleted the refactor/174/hardcoded-loading-animation branch June 3, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmirAgassi AmirAgassi Awaiting requested review from AmirAgassi

@juancwu juancwu Awaiting requested review from juancwu juancwu is a code owner

@teoh4770 teoh4770 Awaiting requested review from teoh4770

@aidantrabs aidantrabs Awaiting requested review from aidantrabs aidantrabs is a code owner

Assignees

@GabeDiniz GabeDiniz

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] Loading Animation duration is hard coded
2 participants
@GabeDiniz @aidantrabs